fix(msi): force termination of stuck processes

Stopping the Windows Explorer process does not always work.  Per default
the MSI Restart Manager will display a warning message after a timeout,
and not attempt to restart Explorer afterwards -- resulting in a black
screen if no other window is open.

Setting the property `MSIRMSHUTDOWN` to `1` will force the termination
of the process when the timeout is reached, which finally allows the
Explorer to be restarted.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(msi): do not completely remove the previous installation when updating

The MSIs we distribute perform so-called "major upgrades".

From the Microsoft docs, we learn that...

> A typical major upgrade **removes a previous version** of an
> application and installs a new version.

Indeed that was the case -- the previous version is uninstalled
completely before the new version gets installed.  Since we install an
extension that's loaded by explorer, the installer will ask the user to
restart Windows Explorer during the uninstallation of the previous
version (and restarting that might not always work as expected).

There is a way to change this behaviour though, using Wix3's
`MajorUpgrade` element.  Through its `Schedule` property it's possible
to define when the removal of the previous version should occur.

The previous value `afterInstallInitialize` is one of two values that
perform a complete uninstall/install sequence.  The new value
`afterInstallExecute` will install new files on top of the previous
installation (depending on the `REINSTALLMODE` I guess) and remove
older files that are not present.
In the case of the extensions this means that the .dlls from the
previous installation will not be touched, as long as the version
embedded in the DLL info didn't change.  This results in the installer
no longer requesting Windows Explorer to restart, which is a big plus :D

I also changed the REINSTALLMODE to `dmus` to allow downgrades as well.

With this change, the request to restart Windows Explorer should
hopefully happen only once an installation was made using an MSI that
contains this change.  Further updates will only request a restart if
the DLL version of these extensions change...

See also:
  - https://learn.microsoft.com/en-us/windows/win32/msi/major-upgrades
  - https://docs.firegiant.com/wix/schema/wxs/majorupgrade/#attributes:~:text=Schedule

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(msi): use standard replace mode for MSI installer

shoudl enable replacing files during install happen only when needed
instead of always

will need to take care of migration from older releases

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8314 from nextcloud/backport/8181/stable-3.16

[stable-3.16] fix(gui): handle invalid file name edge case on Windows

fix(gui): don't append another slash to the relative path

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

refactor: add new filePath method to folder

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(gui): always hide the error label if we are allowed to rename

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(gui): update info text with proper invalid characters

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(gui): handle invalid file name edge case on Windows

File names like "c:blah" would break the usage of the dialogue,
displaying a path like "c://blah" instead.

Apparently `QDir::filePath` checks if the passed file name is an
absolute file name using `!QFileInfo::isRelative`, which is the case if
the second character in the string is a colon -- probably indicating a
drive letter.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8313 from nextcloud/backport/8280/stable-3.16

[stable-3.16] fix(AppImage): bundle client translations

fix(AppImage): bundle client translations

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8312 from nextcloud/backport/8276/stable-3.16

[stable-3.16] fix(delete): fix move to trash in read-only folders

fix(moveToTrash): enable use of move to trash in some automated tests

should improve coverage for move to trash feature to ensure this is
working as expected by users

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(readonly): ignore move to trash for read-èonly items

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(delete): fix move to trash when parent folder is read-only

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(delete): optimize item exist checks when propagating from server

QFileInfo::exists(filename) is the fastest method

alos avoid creating too many QFileInfo instances when we need it for
multiple purposes

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(delete): always print warnings when file deletions fail

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8308 from nextcloud/backport/8228/stable-3.16

[stable-3.16] fix(migration): migrate general network settings.

fix(migration): migrate general network settings.

Signed-off-by: Camila Ayres <hello@camilasan.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8233 from nextcloud/backport/8227/stable-3.16

[stable-3.16] revert: remove duplicated code when copying legacy config to new path.

revert: remove duplicated code when copying legacy config to new path.

This reverts commit a6745bc594ebe388ffadaf6b55fedccce9d0e0d4.
Fix for #8176.

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

prepare for release 3.16.4

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8215 from nextcloud/backport/8209/stable-3.16

[stable-3.16] fix(filesystem): ensure we set a file read-only or read-write on Windows

fix(propagation): ensure we run file removal propagation steps

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(propagation): more logs on folder deletions propagation step

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(propagation): ensure we delete pending folders before terminating

we might forget to run the pending folder deletions when terminating
synchronization

ensure we check if any of them are to be done

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(filesystem): use platform specific API to make a file read-only

on Windows we may fail to mark a file read-only be read-write again
using high level API

switch to use of low level C API from Microsoft

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(filesystem): log more permissions when deleting a file fails

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8214 from nextcloud/backport/8201/stable-3.16

[stable-3.16] fix(gui): resize sharee search results list dependent on required space

fix(gui): resize share search results list dependent on required space

In the case there are more search results present than there's space for
it, always display a scrollbar.  Some QtQuick themes don't make it
obvious that the list is scrollable.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8211 from nextcloud/backport/8200/stable-3.16

[stable-3.16] fix(assert): remove runtime assert that could crash production builds

fix(assert): remove runtime assert that could crash production builds

use debug only assert to remove the possibility that we self inflict
crashes on users

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8199 from nextcloud/backport/8193/stable-3.16

[stable-3.16] Bugfix/do not crash when propagating changes with move or rename

fix(rename): avoid hitting runtime assert when renaming virtual files

when propagating a rename to the child items, we must not make child
items be done from propagator point of view

they will be part of their own propagator item and that will create
issues

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(rename): handle complex rename/move scenario

ensure we do not leak records and properly update them in client
database

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

feat(discovery): add more info for renamed items

add original name
add renamed name
add target name

should make it easier to analyze rename operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

feat(discovery): add missing inode info for discovered files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

perf(discovery): optimize empty strings

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8198 from nextcloud/backport/8195/stable-3.16

[stable-3.16] revert to QFile::remove to remove single files

fix(filesystem): warn when trying to delete an already deleted file

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(filesystem): still use std::filesystem::remove for folders

this API has a way to provide an error when failing to delete a folder

we may want to know why teh folderf ailed to be deleted

QDir::rmdir does not provide any error when failing to delete a folder

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix: Revert "stop using QFile api to delete a single local file"

This reverts commit 58d28ab3306a5cd36d990678416375386d9a0db9.

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8196 from nextcloud/backport/8182/stable-3.16

[stable-3.16] Bugfix/read only windows folders

fix(rmdir): switch to another API for folder removal

current QDir::rmdir API does not provide an error message when failing
to delete

retuse FileSystem::remove that may just works with folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(autotests): do not remove read-only files already removed

the sync engine will remove invalid items inside read-only folders

not needed to remove them in tests and rather checks that they were
indeed removed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

refactor(logs): improve logs around deletions and permissions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(permissions): solve issues with file permissions automated tests

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(read only folder): allow renaming new file inside read-only folders

needed to download a new file inside a read-only folder

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

feat(windows native API): use windows specific API for read-only folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8197 from nextcloud/backport/8189/stable-3.16

[stable-3.16] Bugfix/filesystem remove file not working

fix: use safer conversion from QString to filesystem::path

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

feat: better logs when a file cannot be removed

should log the reason why a file cannot be deleted

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8194 from nextcloud/backport/8190/stable-3.16

[stable-3.16] pin Craft revision to a specific commit

ci: pin craft revision to a specific commit

25.03-nc still has pkg-config in it, which recently got replaced in
Craft by pkgconf

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

ci: temporarily use custom craftmaster fork

this is required to make `General`.`CraftRevision` work as intended.

Revert this after
https://invent.kde.org/packaging/craftmaster/-/merge_requests/7 is
merged.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

build: prepare 3.16.3 release.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #8172 from nextcloud/backport/8168/stable-3.16

[stable-3.16] use specific revision for KDE blueprints that matches the craft cache

ci: use specific revision for KDE blueprints that matches the craft cache

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8169 from nextcloud/backport/8036/stable-3.16

[stable-3.16]  fix(migration): import proxy and general settings from legacy config.

fix: non-void function does not return a value in all control paths.

Signed-off-by: Camila Ayres <hello@camilasan.com>

fix: remove unused var.

Signed-off-by: Camila Ayres <hello@camilasan.com>

chore: make settings keys const static member of ConfigFile class.

Signed-off-by: Camila Ayres <hello@camilasan.com>

chore: rename function, change log level.

Signed-off-by: Camila Ayres <hello@camilasan.com>

fix(migration): import proxy and general settings from legacy config.

Signed-off-by: Camila Ayres <hello@camilasan.com>

chore(migration): remove duplicated code when copying legacy config to new path.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #8166 from nextcloud/backport/8160/stable-3.16

[stable-3.16] fix(msi): allow custom installation directory

fix(msi): allow custom installation directory

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8162 from nextcloud/backport/8156/stable-3.16

[stable-3.16] fix(theme): correct dark/light mode check on Win10

fix(theme): correct dark/light mode check on Win10

`Utility::registryGetKeyValue` returns an invalid QVariant should the
key not exist -- which is the case if that switch has never been toggled
before.

--> Fix this by ensuring the QVariant is valid, and only then try to
convert it to a bool.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>